Enable native histograms fully on the read path #4513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that the query-frontend can receive the implicit native histograms via protobuf, we can enable native histograms fully. Remove previous restriction via limit. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
This was referenced Mar 16, 2023
pstibrany
approved these changes
Mar 16, 2023
| @@ -515,14 +535,25 @@ func testMetadataQueriesWithBlocksStorage( | |||
| firstSeriesInIngesterHead prompb.TimeSeries, | |||
| blockRangePeriod time.Duration, | |||
| ) { | |||
| // This is hacky, don't use for anything serious | |||
There was a problem hiding this comment.
there's worse code out there :)
codesome
reviewed
Mar 16, 2023
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
krajorama
added a commit
that referenced
this pull request
Mar 17, 2023
Followup to #4513 Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
krajorama
added a commit
that referenced
this pull request
Mar 17, 2023
* Add query format to native histograms flag description Followup to #4513 Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Now that the query-frontend can receive the implicit native histograms via protobuf, we can enable native histograms fully.
Remove previous restriction via limit.
Which issue(s) this PR fixes or relates to
Related to: #3478
Fixes: #3992
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]