Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release-2.11 to main #6963

Merged
merged 13 commits into from
Dec 19, 2023
Merged

Merge release-2.11 to main #6963

merged 13 commits into from
Dec 19, 2023

Conversation

leizor
Copy link
Contributor

@leizor leizor commented Dec 19, 2023

#6670

In this PR I'm merging the release-2.11 branch to main branch. Please merge this PR using a merge commit or by using tools/release/merge-approved-pr-branch-to-main.sh script.

grafanabot and others added 12 commits December 1, 2023 10:16
…6790)

* Use BucketIndexBlocksFinder instead of BucketScanBlocksFinder

The use of BucketScanBlocksFinder was supposed to be removed in
#6673 but its counterpart
BucketIndexBlocksFinder was accidentally removed instead.

This reverses that.

* Remove BlocksFinderBucketScan

* Update docs wrt. bucket scanning option

* Remove alert and runbook for bucket scanning

(cherry picked from commit ff8a70a)

Co-authored-by: Justin Lei <lei.justin@gmail.com>
* Draft release notes for 2.11

* Apply suggestions from code review

Co-authored-by: Charles Korn <charleskorn@users.noreply.github.com>

* More code review responses

* More mode code review responses

* Update docs/sources/mimir/release-notes/v2.11.md

Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>

* More more more code review responses

---------

Co-authored-by: Charles Korn <charleskorn@users.noreply.github.com>
Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
This also adds a bit more details for how to use the feature.

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
(cherry picked from commit f52486a)

Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
…e bucket (#6812)

* store-gateway: use bucket index instead of scanning the bucket

This is a follow-up to 6673, similar change to 6779

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>

* Fix TestStoreGateway_InitialSyncFailure

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>

* Fix TestStoreGateway_InitialSyncWithDefaultShardingEnabled

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>

* Fix TestBucketStores_SyncBlocks

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>

* Fix TestBucketStores_InitialSyncShouldRetryOnFailure

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>

* Fix TestBucketStores_InitialSync

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>

* Fix TestBucketStores_Series_ShouldCorrectlyQuerySeriesSpanningMultipleChunks

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>

* Fix TestBucketStore_Series_ShouldQueryBlockWithOutOfOrderChunks

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>

* Fix TestBucketStores_deleteLocalFilesForExcludedTenants

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>

* Fix TestStoreGateway_SyncShouldKeepPreviousBlocksIfInstanceIsUnhealthyInTheRing

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>

* Fix TestStoreGateway_SeriesQueryingShouldEnforceMaxChunksPerQueryLimit

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>

* Fix read-write mode integration tests

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>

* Clean up users in integration tests more often

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>

* Update CHANGELOG.md

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>

* Fix TestGettingStartedWithGossipedRing

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>

* Fix Test_MaxSeriesAndChunksPerQueryLimitHit

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>

* Remove debug option

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>

---------

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
(cherry picked from commit 1a459bb)

Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
…6818)

* querier: default to using batch.NewChunkMergeIterator

This is a follow-up of 6673

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>

* Update CHANGELOG.md

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>

* Remove configurability of chunkIteratorFunc

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>

* Remove configurability of chunkIteratorFunc in streaming code

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>

* Remove unnecessary type declaration

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>

---------

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
(cherry picked from commit e09acc9)

Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Sync to the newly created mimir-release-2.11 branch that includes
grafana/mimir-prometheus#572

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
(cherry picked from commit a5badbb)

Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
* Update 2.10 changelog and release notes

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>

* Update CHANGELOG.md

---------

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
(cherry picked from commit 9bb55ff)

Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
#6956)

* Fix .metricsUsed in mimirtool analyze rule-file (#6953)

* Fix .metricsUsed in mimirtool analyze rule-file

This field wasn't populated.

Fixes #6952

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>

* Update CHANGELOG.md

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>

* make license

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>

---------

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
(cherry picked from commit 6a7bee2)
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>

* Update release notes

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>

---------

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
* Add mark-blocks tool to release notes

* Update VERSION to 2.11.0-rc.0
@leizor leizor requested review from grafanabot and a team as code owners December 19, 2023 00:43
@leizor leizor force-pushed the merge-release-2.11-to-main branch 2 times, most recently from fa13c33 to 644d913 Compare December 19, 2023 00:54
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we not want to get the changes to VERSION too?

@leizor
Copy link
Contributor Author

leizor commented Dec 19, 2023

do we not want to get the changes to VERSION too?

I'm not sure--maybe we don't do that until the main release?

I was following the instruction here: https://github.com/grafana/mimir/blob/main/tools/release/create-pr-to-merge-release-branch-to-main.sh#L63

@dimitarvdimitrov
Copy link
Contributor

ah, thanks for pointing this out. I would trust the process 😄

@leizor leizor merged commit e61d593 into main Dec 19, 2023
28 checks passed
@leizor leizor deleted the merge-release-2.11-to-main branch December 19, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants