Mimir / Reads dashboard query scheduler queue duration breakout improvements #7098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onal queue dimensions
…onal queue dimensions
charleskorn
approved these changes
Jan 10, 2024
Comment on lines
+1035
to
+1044
| legendFormat: '%sth Percentile: {{ %s }}' % [std.lstripChars(percentile, '0.'), labelBreakouts], | ||
| refId: 'A', | ||
| } | ||
| for percentile in percentiles | ||
| ]; | ||
| local averageTargets = [ | ||
| { | ||
| expr: averageExprTmpl % [metricName, selector, labelBreakouts, multiplier, metricName, selector, labelBreakouts], | ||
| format: 'time_series', | ||
| legendFormat: 'Average: {{ %s }}' % [labelBreakouts], |
There was a problem hiding this comment.
[nit] If we're only showing one percentile or just the average on a panel, the %sth Percentile: / Average: prefix is superfluous
There was a problem hiding this comment.
I figured I would leave it for the option as the func here can still be used show them both on the same chart if desired.
francoposa
deleted the
francoposa/mimir-reads-dashboard-query-scheduler-queue-duration-breakout-improvements
branch
|
@francoposa just noticed this only applies to the "Reads" dashboard, but not the "Remote Ruler Reads" dashboard. Should we adjust the way these dashboards are built so we don't have to remember to make changes in both dashboards perhaps? |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Improves the Query Scheduler Time in Queue breakout.
Currently it has too many series to be helpful at a glance, and it's not particularly effective to have 99th percentile and 50th percentile/average on the same panel, because the graph is scaled to accommodate the 99th percentile, and the 50th %ile and average get squashed at the bottom:
Confusing:
The new better version breaks it out into a row with 3 panels, one each for 99th percentile, 50th percentile, and Average:
Better:
Also extended the jsonnet function to allow all these panels to be build from the same function.
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.