mimir ruler reads dashboard query scheduler queue duration breakout improvements #7163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francoposa
deleted the
francoposa/mimir-ruler-reads-dashboard-query-scheduler-queue-duration-breakout-improvements
branch
charleskorn
reviewed
Jan 19, 2024
There was a problem hiding this comment.
I don't think this is quite right, looks like we'll show data on the standard query path's query-scheduler rather than the ruler query path's query-scheduler.
Also, it might be good to pull these rows shared by both dashboards out to a common place to make it easier to make changes to both in one place.
| $.qpsPanel('cortex_query_scheduler_queue_duration_seconds_count{%s}' % $.jobMatcher($._config.job_names.ruler_query_scheduler)) + | ||
| $.panelDescription(title, description), | ||
| $.panelDescription(title, description) + | ||
| $.qpsPanel('cortex_query_scheduler_queue_duration_seconds_count{%s}' % $.jobMatcher($._config.job_names.query_scheduler)) |
There was a problem hiding this comment.
Shouldn't this refer to $._config.job_names.ruler_query_scheduler?
There was a problem hiding this comment.
(this also applies to a bunch of changes below - looks like they should all refer to ruler_query_scheduler, not query_scheduler)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous PR we did this breakout of one panel into three for the Reads dashboard but forgot to apply the same improvements for Remote Ruler Reads
What this PR does
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.