-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S3 multipart enchancement #7350
base: main
Are you sure you want to change the base?
Conversation
9eae28c
to
cef749e
Compare
Thanks for the PR! I've converted it to a draft until the upstream Thanos objstore PR is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to contribute. It would be helpful if you could explain the motivation for adding this option.
The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase |
upstream PR has been merged and updated in mimir modules. I put the PR as ready to review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you need to run make reference-help
to update the CLI flag everywhere. Could you also add this experimental option to about-versioning.md
under the ingester section?
What this PR does
Allow to disable multipart uploads in storage provider and in tools and to configure part size in tools.
note: a PR has been submitted to thanos-io/objstore (thanos-io/objstore#100) to add
DisableMultipart
option. I've backport the patch manually in vendor/ while waiting for this PR to be merged.Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.