S3 multipart enchancement #7350
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
fatpat
force-pushed
the
s3PartSize
branch
2 times, most recently
from
9eae28c
to
cef749e
Compare
|
Thanks for the PR! I've converted it to a draft until the upstream Thanos objstore PR is merged. |
andyasp
reviewed
Feb 21, 2024
2 tasks
|
The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase |
upstream PR has been merged and updated in mimir modules. I put the PR as ready to review |
56quarters
reviewed
May 13, 2024
There was a problem hiding this comment.
Looks like you need to run make reference-help to update the CLI flag everywhere. Could you also add this experimental option to about-versioning.md under the ingester section?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Allow to disable multipart uploads in storage provider and in tools and to configure part size in tools.
note: a PR has been submitted to thanos-io/objstore (thanos-io/objstore#100) to add
DisableMultipartoption. I've backport the patch manually in vendor/ while waiting for this PR to be merged.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.