Add partitions ring support to Distributor.QueryStream() #7388
Conversation
| if len(replicationSets) == 1 { | ||
| zoneSorter = queryIngestersRingZoneSorter(replicationSets[0]) | ||
| } |
There was a problem hiding this comment.
nitpick, but i'd even panic if that's not the case
| } | ||
| } | ||
|
|
||
| // LabelValuesForLabelName returns all of the label values that are associated with a given label name. | ||
| func (d *Distributor) LabelValuesForLabelName(ctx context.Context, from, to model.Time, labelName model.LabelName, matchers ...*labels.Matcher) ([]string, error) { | ||
| replicationSet, err := d.GetIngesters(ctx) | ||
| //nolint:staticcheck |
There was a problem hiding this comment.
is this because of the deprecated notice?
There was a problem hiding this comment.
The usage of deprecated functions will disappear as soon as I complete this work (over the course of few more PRs).
pracucci
force-pushed
the
query-partitions
branch
from
bb43026
to
1af25c8
Compare
Signed-off-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
pracucci
force-pushed
the
query-partitions
branch
from
1af25c8
to
3414ac9
Compare
Signed-off-by: Marco Pracucci <marco@pracucci.com>
…estStorage Signed-off-by: Marco Pracucci <marco@pracucci.com>
There was a problem hiding this comment.
Very nice set of tests. Good job @dimitarvdimitrov and @pracucci!
| expectedQueriedIngesters: 5 /* zone-a */ + 2, /* the two failed fall back to zone-b */ | ||
| expectedErr: errFail, | ||
| }, | ||
| "should succeed if there unhealthy ingesters in every zone but unhealthy ingesters own different partitions": { |
There was a problem hiding this comment.
The coolest property of the new system ;)
All done by Dimitar! |
I thought so, but wasn't sure :) |
Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
|
Going to merge it since I don't think that what we do in this PR is particularly contentious. I there will be post merge comments, I will quickly address them in a follow up PR. |
| "should fail if all the ingesters owning a partition are in JOINING state": { | ||
| ingesterStateByZone: map[string]ingesterZoneState{ | ||
| "zone-a": {numIngesters: 5, happyIngesters: 5, ringStates: []ring.InstanceState{ring.JOINING, ring.ACTIVE, ring.ACTIVE, ring.ACTIVE, ring.ACTIVE}}, | ||
| "zone-b": {numIngesters: 5, happyIngesters: 5, ringStates: []ring.InstanceState{ring.JOINING, ring.ACTIVE, ring.ACTIVE, ring.ACTIVE, ring.ACTIVE}}, | ||
| }, |
There was a problem hiding this comment.
you can also add a case where different ingesters in the two zones are LEAVING (or JOINING) but the query still succeeds
There was a problem hiding this comment.
Good idea, done in 19650e3
…estStorage Signed-off-by: Marco Pracucci <marco@pracucci.com>
What this PR does
In this PR I'm adding partitions ring support to
Distributor.QueryStream(). Other Distributor's query functions don't use partitions ring yet and their support will be introduced in follow up PRs.Notes:
-querier.prefer-availability-zone. The config is hidden in the doc because currently used only by experimental ingest storage.Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.