Move -querier.minimize-ingester-requests from experimental to advanced #7638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pracucci
reviewed
Mar 18, 2024
There was a problem hiding this comment.
I prefer if we keep this option for now, because I'm not convinced that minimising ingester requests is the right approach for the experimental "ingest storage" architecture we're working on. I suggest to mark this option as advanced instead of experimental and keep it enabled by default for now.
duricanikolic
force-pushed
the
yuri/deprecated-features
branch
from
1ee4741
to
8410b28
Compare
duricanikolic
changed the title
Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
duricanikolic
force-pushed
the
yuri/deprecated-features
branch
from
8410b28
to
8a0eb67
Compare
pracucci
approved these changes
Mar 18, 2024
4 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR is needed for the release of Mimir 2.12.
Experimental CLI flag
-querier.minimize-ingester-requestshas been enabled by default and marked for deletion in Mimir 2.12 in #6174.After a more detailed analysis, we realized that this CLI flag might be still needed. Therefore, this PR sets it as advanced.
Which issue(s) this PR fixes or relates to
Part of #7542
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.