Remove dependency on github.com/prometheus/common/log #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github.com/prometheus/common/log was removed in favor of Prometheus internally using github.com/go-kit/kit/log (and later github.com/go-kit/log). This exporter still uses the removed package, which prevents downstream importers from being able to upgrade the prometheus/common module. Signed-off-by: Robert Fratto <robertfratto@gmail.com>
mattdurham
reviewed
Oct 5, 2021
| @@ -13,8 +13,9 @@ require ( | |||
| github.com/pkg/errors v0.9.1 | |||
| github.com/prometheus/client_golang v1.11.0 | |||
| github.com/prometheus/client_model v0.2.0 | |||
| github.com/prometheus/common v0.26.0 | |||
| github.com/shirou/gopsutil v3.21.8+incompatible // indirect | |||
There was a problem hiding this comment.
Did this come along for the ride or was it intentional?
There was a problem hiding this comment.
🤔 let me go mod tidy again
There was a problem hiding this comment.
yeah, go mod tidy added this, probably as a result of me using a newer Go version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
github.com/prometheus/common/log was removed in favor of Prometheus internally using github.com/go-kit/kit/log (and later
github.com/go-kit/log). This exporter still uses the removed package, which prevents downstream importers from being able to upgrade the prometheus/common module.
This is a temporary PR for the Grafana Agent to use until percona#355 is merged.
Signed-off-by: Robert Fratto robertfratto@gmail.com