Skip to content

Commit

Permalink
Add spacing between words in notifications. (#4574)
Browse files Browse the repository at this point in the history
# What this PR does

Add a space between "team" and the quoted team name. Currently this
renders as:

```
This phone number has been connected to Grafana OnCall team"ops"
```

(which is an SMS I just received on my phone.)

## Which issue(s) this PR closes

Closes [issue link here]

<!--
*Note*: if you have more than one GitHub issue that this PR closes, be
sure to preface
each issue link with a [closing
keyword](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue).
This ensures that the issue(s) are auto-closed once the PR has been
merged.
-->

## Checklist

- [ ] Unit, integration, and e2e (if applicable) tests updated
- [ ] Documentation added (or `pr:no public docs` PR label added if not
required)
- [ ] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
  • Loading branch information
seizethedave committed Jun 21, 2024
1 parent 16e98da commit 5cf921b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions engine/apps/phone_notifications/phone_backend.py
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,7 @@ def send_test_sms(self, user):

def _notify_connected_number(self, user):
text = (
f"This phone number has been connected to Grafana OnCall team"
f"This phone number has been connected to Grafana OnCall team "
f'"{user.organization.stack_slug}"\nYour Grafana OnCall <3'
)
try:
Expand All @@ -392,7 +392,7 @@ def _notify_connected_number(self, user):

def _notify_disconnected_number(self, user, number):
text = (
f"This phone number has been disconnected from Grafana OnCall team"
f"This phone number has been disconnected from Grafana OnCall team "
f'"{user.organization.stack_slug}"\nYour Grafana OnCall <3'
)
try:
Expand Down

0 comments on commit 5cf921b

Please sign in to comment.