Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spacing between words in notifications. #4574

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Conversation

seizethedave
Copy link
Contributor

What this PR does

Add a space between "team" and the quoted team name. Currently this renders as:

This phone number has been connected to Grafana OnCall team"ops"

(which is an SMS I just received on my phone.)

Which issue(s) this PR closes

Closes [issue link here]

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • Added the relevant release notes label (see labels prefixed w/ release:). These labels dictate how your PR will
    show up in the autogenerated release notes.

Otherwise this renders as:

This phone number has been connected to Grafana OnCall team"ops"
@seizethedave seizethedave requested a review from a team as a code owner June 21, 2024 18:20
@CLAassistant
Copy link

CLAassistant commented Jun 21, 2024

CLA assistant check
All committers have signed the CLA.

@matiasb matiasb added pr:no public docs Added to a PR that does not require public documentation updates release:ignore PR will not be added to release notes labels Jun 21, 2024
Copy link
Contributor

@matiasb matiasb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@matiasb matiasb added this pull request to the merge queue Jun 21, 2024
Merged via the queue into dev with commit 5cf921b Jun 21, 2024
25 of 27 checks passed
@matiasb matiasb deleted the davidgrant/notify-spacing branch June 21, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates release:ignore PR will not be added to release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants