Allow skipping the who-resolved info in slack posts #4207
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
All resolved alerts currently get an extra line of to say what resolved the alert (for us usually the alert source rather than a person), which I think not normally needed, and anyway repeated in the Plugin UI or the message log inside the Slack thread. So to save scroll-space on the Slack UI I'm proposing to remove the it. Implemented as a
FEATURE_SKIP_SLACK_RESOLVED_BY
for now, but TBH I'd prefer it to default True as I can't see it's that useful.There is one problem though - when combined with #4206 this means resolved alerts have no buttons or other Slack Attachments, so there is no green coloured sidebar to highlight this is a resolved alert group. Only the lack of buttons & a red sidebar, which might be enough but not perfect. In our home-grown equivalent to OnCall we post slack messages as all Attachments and no Blocks to solve this, as AFAIK Slack do not allow adding a coloured sidebar to Blocks.
I'd obviously be happy to switch the existing Slack title/message Blocks over to Attachments in this or another PR.
Which issue(s) this PR closes
Further work towards #4165
Checklist
I've not added any extra tests/docs yet, awaiting feedback on whether this feature is acceptable & in what form you'd like extra work before doing so.
pr:no public docs
PR label added if not required)release:
). These labels dictate how your PR willshow up in the autogenerated release notes.