Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests are disabled and out of date in response_parser_test.go #117

Closed
fridgepoet opened this issue Mar 30, 2023 · 2 comments
Closed

Tests are disabled and out of date in response_parser_test.go #117

fridgepoet opened this issue Mar 30, 2023 · 2 comments

Comments

@fridgepoet
Copy link
Member

What happened:
response_parser_test.go_ has an underscore at the end of the file name. https://github.com/grafana/opensearch-datasource/blob/main/pkg/opensearch/response_parser_test.go_

Not sure if this was intentional; it's been there since the first commit of this repo.

The consequence is that no test in that file is run under go test.

  • Rename it without the _ at the end.
  • All of the tests need to be verified and assertions need to be updated.
@fridgepoet
Copy link
Member Author

This is what the test was copied from originally, can probably use it to update some of the tests:
https://github.com/grafana/grafana/blob/main/pkg/tsdb/elasticsearch/response_parser_test.go

@fridgepoet fridgepoet self-assigned this May 16, 2023
@fridgepoet fridgepoet changed the title Update tests in response_parser_test.go Enable tests in response_parser_test.go May 16, 2023
@fridgepoet fridgepoet changed the title Enable tests in response_parser_test.go Tests are disabled and out of date in response_parser_test.go May 17, 2023
@fridgepoet
Copy link
Member Author

Closing this now but a few more tests need to be re-enabled #175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

1 participant