Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: Tables need to be converted to data frames #175

Closed
Tracked by #192
fridgepoet opened this issue May 17, 2023 · 0 comments · Fixed by #186
Closed
Tracked by #192

Backend: Tables need to be converted to data frames #175

fridgepoet opened this issue May 17, 2023 · 0 comments · Fixed by #186

Comments

@fridgepoet
Copy link
Member

What happened:
While enabling some old tests, we discovered there were some assertions on "Table" objects. These seem to have been deprecated in the past and converted already in Elasticsearch grafana/grafana#34710.

For example in this test

So(queryRes.Tables, ShouldHaveLength, 1)

I expected that queryRes should have some Frames with the old data that was asserted in the Tables, but currently Frames is empty.

What you expected to happen:
The formerly-populated Tables object should be transferred to Frames. Every test that involves a Table should be updated and probably passing with the equivalent data.

How to reproduce it (as minimally and precisely as possible):

  • Go to response_parser_test.go
  • Enable a test that makes assertions with Tables
  • Comment out everything after queryRes
  • Inspect the the queryRes object, for example with a debugger
  • It should probably have the formerly-asserted data in the data Frames

Environment:

  • Plugin version: v2.4.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant