-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable response_parser_test.go #174
Conversation
Backend code coverage report for PR #174
|
Frontend code coverage report for PR #174 |
Levitate is-compatible report: 🔍 Resolving @grafana/data@latest... 🔬 Checking compatibility between ./src/module.ts and @grafana/data@9.5.2... 🔬 Checking compatibility between ./src/module.ts and @grafana/ui@9.5.2... 🔬 Checking compatibility between ./src/module.ts and @grafana/runtime@9.5.2... 🔬 Checking compatibility between ./src/module.ts and @grafana/e2e-selectors@9.5.2... ✔️ ./src/module.ts appears to be compatible with @grafana/data,@grafana/ui,@grafana/runtime,@grafana/e2e-selectors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides my note on what I think So(seriesOne.Points, ShouldHaveLength, 2)
from the original is checking (I think it's checking the number of data points while you're checking the number of fields per data point) looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
What this PR does / why we need it:
es
toclient
Discovered that some table to data frame conversion has not yet been done in this plugin. The tests that depend on that are now commented and an issue was created #175.
Which issue(s) this PR fixes:
Contributes to #117
Other information
Something I found interesting was that time in the "Points" used to be stored as float64 epoch time, so a "1000" time was the same as time.UnixMilli(1000).UTC() which is the same as time.Date(1970, time.January, 1, 0, 0, 1, 0, time.UTC). These are all typed now in the time-typed Fields.