This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
Introduce symdb #767
Merged
Introduce symdb #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll merge this in few hours ! |
|
Unfortunately, this introduced a dependency on https://github.com/dgryski/go-groupvarint for which no license has been specified. I have created an issue there: dgryski/go-groupvarint#3 Could you update the dependency once the issue has been resolved? This will ensure automatic license checkers also recognize this is fine. |
|
License updated for groupvarint. |
simonswine
added a commit
to simonswine/pyroscope
that referenced
this pull request
Jun 30, 2023
* Increase parquet writer PageBufferSize * reduce by 2 page buffer size * Introduce symdb * Add chunk format description * Add chunk format description * Improve naming * Implement stack trace appender * Limit chunk by number of nodes * Stacktrace ID is uint32 * Add in-memory stacktrace resolver * Add writer * Add writer * Fix stacktrace resolver * Single pass write * Index file refactoring * Fixes, improvements, notes * Ignore empty stacktraces * Fix chunk boundary check * Fix tests * Store chunk headers sorted * Make chunk index explicit * Add file reader * Use group varint encoding * Refine stacktrace tree * Stacktrace tree race condition elimination * Remove unused stacktracesResolve.do * Better nil coalescence in stack trace appender * Format imports * Use the new symDB package (grafana/phlare#770) * Ingest stacktraces in the new symdb * Setup read in memory read path * Fix up a comment placement * Start setting up the read path * Update to uint32 * Introduce stacktrace partition (grafana/phlare#775) * Introduce stacktrace partition This determines the partition of a particular profile, by looking first at its metadata: * If there is a `Filename` on the main mapping use its filepath.Base(Filename) * Failing that take the externally supplied `service_name` * Fallback to `unknown` Take the underlying string value and hash. * After a chat with cyril we decided to not longer mod and use the hash straight away. We don't wanted to risk the collisions of two very big stacktrace applications. * Remove reconstructMeta from singleBlockQuerier * support multiple versions of stacktraces resolver * Integrate v2 reader for stacktraces in block reader * Fixes tests * Rewrite locations Ids * Rewrite test for counting uniq stacktraces * lint and fmt * Fixes more tests * Fixes leftover from todo --------- Co-authored-by: Christian Simon <simon@swine.de> * Use prefixed bucket for symbols * Initialize locationsIdsByStacktraceID * Initialize locationsIdsByStacktraceID for pprof as well * Fix chunk headers sort * Inline node alloc * Mapping filename extraction * Tidy go.mod * Fix TestHeadIngestStacktraces * Use symdb.DefaultDirName * Sort mappings on write * Make column iterator to respect the context * Fix unexpected EOF on stacktrace chunk unmarshal * Fix symbols upload * Fix symbols upload * Release fetched data * 3MB Page Buffer Size * Sort stacktraces IDs as expected by the resolver --------- Co-authored-by: Cyril Tovena <cyril.tovena@gmail.com> Co-authored-by: Christian Simon <simon@swine.de>
This was referenced Jul 19, 2023
kolesnikovae
added
kind/enhancement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For context, please refer to the proposal.
TODO:
mapping_namefield to the Profile schema and ensure it is present at read time (merge step):Mapping.filename(mapping of the main binary) if it is available and valid (e.g is not "[vdso]");service_namelabel if it is available (I'm not too sure if it should take precedence overMapping.filenameor not);profiles.parquettable does not change (ordered by series ID);