This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
Fix backwards compatibility with block version 1 #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also adds a Test for block version compatibility.
|
Did you figure why it broke ? |
cyriltovena
reviewed
Jun 28, 2023
| joinIters []query.Iterator | ||
| ) | ||
|
|
||
| if b.meta.Version >= 2 { |
There was a problem hiding this comment.
I think I want to include total sample in v2 WDYT ?
There was a problem hiding this comment.
I would really throw around with versions and make that version+1, also the sorted should be a version+1
simonswine
commented
Jun 28, 2023
Comment on lines
+87
to
+88
| case uint32: | ||
| return int64(i) |
There was a problem hiding this comment.
Problem #2, panic with uint32s
simonswine
commented
Jun 28, 2023
| ) | ||
|
|
||
| if b.meta.Version >= 2 { | ||
| joinIters = []query.Iterator{ | ||
| b.profiles.columnIter(ctx, "SeriesIndex", newMapPredicate(lblsPerRef), "SeriesIndex"), | ||
| b.profiles.columnIter(ctx, "TimeNanos", query.NewIntBetweenPredicate(model.Time(params.Start).UnixNano(), model.Time(params.End).UnixNano()), "TimeNanos"), | ||
| b.profiles.columnIter(ctx, "StacktracePartition", nil, "StacktracePartition"), |
There was a problem hiding this comment.
Problem #1: This requires the column to be there, maybe should have a orNull predicate or something.
simonswine
added a commit
to simonswine/pyroscope
that referenced
this pull request
Jun 30, 2023
This also adds a Test for block version compatibility.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#767 broke compatibility with version 1 blocks, this fixes the two issues and also adds sample blocks and tests to ensure compatibility.