Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
devDependencies
for the scaffolded plugins (most of these are just for "clarity", as they were already defined using carets^
which already allowed all possible minor and patch versions)4.8.4
- this is temporary, and the reason is to hide the typescript version mismatch because of our grafana-eslint packageMajor updates
webpack-cli
(4->5)What's next with Typescript?
The goal is to update typescript to the latest possible version, too. In order to do this first we need to update
@typescript-eslint/eslint-plugin
(so it supports TS >5) in eslint-config-grafana, release a new version of it, and then update it in thecreate-plugin
.📦 Published PR as canary version:
Canary Versions
✨ Test out this PR locally via:
npm install @grafana/create-plugin@1.3.2-canary.232.f3fd3ea.0 # or yarn add @grafana/create-plugin@1.3.2-canary.232.f3fd3ea.0