Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update dev-dependencies #232

Merged
merged 2 commits into from
May 18, 2023

Conversation

leventebalogh
Copy link
Collaborator

@leventebalogh leventebalogh commented Apr 17, 2023

What changed?

  • updated the devDependencies for the scaffolded plugins (most of these are just for "clarity", as they were already defined using carets ^ which already allowed all possible minor and patch versions)
  • "downgraded" and fixed typescript to version 4.8.4 - this is temporary, and the reason is to hide the typescript version mismatch because of our grafana-eslint package

Major updates

  • webpack-cli (4->5)
    • no changes that should affect us

What's next with Typescript?

The goal is to update typescript to the latest possible version, too. In order to do this first we need to update @typescript-eslint/eslint-plugin (so it supports TS >5) in eslint-config-grafana, release a new version of it, and then update it in the create-plugin.

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @grafana/create-plugin@1.3.2-canary.232.f3fd3ea.0
# or 
yarn add @grafana/create-plugin@1.3.2-canary.232.f3fd3ea.0

@leventebalogh leventebalogh added dependencies Update one or more dependencies version chore Other changes that don't modify src or test files labels Apr 17, 2023
@leventebalogh leventebalogh self-assigned this Apr 17, 2023
@jackw jackw force-pushed the leventebalogh/update-common-dev-dependencies branch from 9219513 to f3fd3ea Compare May 16, 2023 10:56
@jackw jackw added create-plugin related to the create-plugin tool patch Increment the patch version when merged release Create a release when this pr is merged labels May 16, 2023
Copy link
Collaborator

@jackw jackw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@leventebalogh leventebalogh merged commit 22a0510 into main May 18, 2023
@leventebalogh leventebalogh deleted the leventebalogh/update-common-dev-dependencies branch May 18, 2023 13:15
@grafanabot
Copy link
Contributor

🚀 PR was released in @grafana/create-plugin@1.3.2 🚀

@grafanabot grafanabot added the released This issue/pull request has been released. label May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Other changes that don't modify src or test files create-plugin related to the create-plugin tool dependencies Update one or more dependencies version patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
Development

Successfully merging this pull request may close these issues.

3 participants