Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin E2E: Make getQueryEditorRow method sync #699

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Plugin E2E: Make getQueryEditorRow method sync #699

merged 1 commit into from
Jan 29, 2024

Conversation

sunker
Copy link
Contributor

@sunker sunker commented Jan 25, 2024

What this PR does / why we need it:

There's absolutely no point in letting the getQueryEditorRow method be async. This PR changes that, and simply resolves the locator synchronously.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@sunker sunker requested a review from academo January 25, 2024 14:14
@sunker sunker requested a review from a team as a code owner January 25, 2024 14:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 25, 2024 •
edited

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new patch release.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

@sunker sunker added patch Increment the patch version when merged release Create a release when this pr is merged labels Jan 25, 2024
leventebalogh
leventebalogh approved these changes Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@leventebalogh leventebalogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup 👏

@sunker sunker merged commit 9a57383 into main Jan 29, 2024
20 of 22 checks passed
@sunker sunker deleted the plugin-e2e/refactor-query-editor-row branch January 29, 2024 12:03
@grafana-plugins-platform-bot
Copy link

🚀 PR was released in @grafana/plugin-e2e@0.11.1 🚀

@grafana-plugins-platform-bot grafana-plugins-platform-bot bot added the released This issue/pull request has been released. label Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leventebalogh leventebalogh leventebalogh approved these changes

@academo academo Awaiting requested review from academo

Assignees
No one assigned
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
Plugins Platform / Grafana Community
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sunker @leventebalogh