Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for build errors with undefined vs null #45

Merged
merged 2 commits into from
Sep 20, 2021
Merged

fix for build errors with undefined vs null #45

merged 2 commits into from
Sep 20, 2021

Conversation

srclosson
Copy link
Member

Fixes build errors where typings have changed, and null is no longer valid, but undefined is.

@srclosson srclosson self-assigned this Sep 20, 2021
@srclosson srclosson requested a review from a team September 20, 2021 15:29
yesoreyeram
yesoreyeram approved these changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@yesoreyeram yesoreyeram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srclosson srclosson merged commit 4af7582 into master Sep 20, 2021
@srclosson srclosson deleted the src/build-errors-null branch September 20, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yesoreyeram yesoreyeram yesoreyeram approved these changes

@toddtreece toddtreece Awaiting requested review from toddtreece

Assignees

@srclosson srclosson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@srclosson @yesoreyeram @toddtreece