Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Remove build errors from plugins due to pinned react #46

Merged
merged 4 commits into from
Sep 21, 2021

Conversation

srclosson
Copy link
Member

Not totally sure if this is the reason, but removed the react version, and that seems to fix the problems.

Would like to get this merged in.

@srclosson srclosson self-assigned this Sep 21, 2021
@srclosson srclosson requested a review from a team September 21, 2021 17:49
Copy link
Member

@toddtreece toddtreece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srclosson mentioned that this was tested in drone. lgtm if it fixes the issue 👍

@srclosson srclosson merged commit 9d4abb6 into master Sep 21, 2021
@srclosson srclosson deleted the src/fix-build-errors branch September 21, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants