Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add observability to consume mode #36

Closed
simonswine opened this issue Dec 9, 2020 · 1 comment · Fixed by #37
Closed

Add observability to consume mode #36

simonswine opened this issue Dec 9, 2020 · 1 comment · Fixed by #37
Assignees

Comments

@simonswine
Copy link
Collaborator

simonswine commented Dec 9, 2020

The consume mode currently is not exposing any status of how successful its remote_write requests.

Ideally it should expose metrics about the outcome of the remote_write requests in a similar way as the "produce" mode does.

The pulsar client itself registers some metrics about consume the messages from the bus.

Their metrics definition is here:

Ideally the metric vector includes the tenant ID if set, so we can figure which tenant fails to deliver remote_write requests

@simonswine
Copy link
Collaborator Author

Currently the consume mode itself is not merged yet #34, but should be fairly soon

/cc @56quarters

@56quarters 56quarters self-assigned this Dec 11, 2020
@simonswine simonswine mentioned this issue Dec 14, 2020
2 tasks
56quarters added a commit that referenced this issue Dec 22, 2020
Add metrics (writes and error counts, timing) for consumer mode

Fixes #36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants