Add metrics (writes and error counts, timing) for consumer mode #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
reviewed
Dec 14, 2020
There was a problem hiding this comment.
Nice one @56quarters that looks already pretty close. See my comments in line.
I think it would be great if we could cover the metrics as part of the integration test through https://github.com/prometheus/client_golang/tree/master/prometheus/testutil
|
I'll take a look at testing metrics as part of the integration tests. |
* Use single metrics struct for producer and consumer * Move ownership of metrics to App (singleton instance) * Add tenant ID to all metrics emitted * Assorted cleanup
56quarters
force-pushed
the
consumer-metrics
branch
3 times, most recently
from
b81752b
to
b06d66a
Compare
56quarters
force-pushed
the
consumer-metrics
branch
from
472b869
to
f5ce0a3
Compare
simonswine
reviewed
Dec 21, 2020
simonswine
reviewed
Dec 21, 2020
* Use default registry by default since other libraries do (pulsar client) and only use a fresh registry for our integration tests.
simonswine
approved these changes
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36