Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign drone config #43

Merged
merged 5 commits into from
Oct 7, 2021
Merged

Sign drone config #43

merged 5 commits into from
Oct 7, 2021

Conversation

simonswine
Copy link
Collaborator

This signs drone config, to avoid security implications from unauthorized changes to the drone config.

@simonswine simonswine requested a review from a team October 7, 2021 08:10
chaudum
chaudum approved these changes Oct 7, 2021
View reviewed changes
Copy link

@chaudum chaudum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.drone/drone.yml Show resolved Hide resolved
MichelHollands
MichelHollands approved these changes Oct 7, 2021
View reviewed changes
Copy link

@MichelHollands MichelHollands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Shame you have to store json in the .yml file though.

@simonswine
Copy link
Collaborator Author

LGTM. Shame you have to store json in the .yml file though.

And I thought YAML is just superset of JSON

@simonswine simonswine merged commit 9e7eb11 into master Oct 7, 2021
@rfratto rfratto mentioned this pull request Mar 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaudum chaudum chaudum approved these changes

@MichelHollands MichelHollands MichelHollands approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@simonswine @chaudum @MichelHollands