Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build image references #47

Merged
merged 3 commits into from
Mar 8, 2023
Merged

Update build image references #47

merged 3 commits into from
Mar 8, 2023

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Mar 8, 2023

No description provided.

@rfratto rfratto requested a review from tpaschalis March 8, 2023 20:01
@rfratto
Copy link
Member Author

rfratto commented Mar 8, 2023

I don't understand yet why the integration tests time out when using Go 1.20, but they were fine with Go 1.14. 🤔

@rfratto
Copy link
Member Author

rfratto commented Mar 8, 2023

Looking at the actions history, it does seem that the integration tests are prone to flaking, and it was also timing out in #43 from 2021. I'm tempted to merge this with the flaky integrations test and revisit before putting out a new version.

WDYT @tpaschalis?

@rfratto
Copy link
Member Author

rfratto commented Mar 8, 2023

OK yeah it passed on a rerun and flaked in the past so I'm going to merge for now and revisit later.

@rfratto rfratto merged commit f033edb into master Mar 8, 2023
@rfratto rfratto deleted the update-build-image-refs branch March 8, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant