Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge feat-shared-interner to v2.17.1-grafana #3

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Apr 3, 2020

Same commit as before, nothing has changed. Should be good to go.

This commit exposes the string interner globally with a shared pool and
modifies both the scraper and remote_write to use that shared pool.

Note that the string_interner_zero_reference_releases_total now has a
different namespace and subsystem from what it was initially set to in
the RW code.

Signed-off-by: Robert Fratto <robert.fratto@grafana.com>
@rfratto rfratto requested a review from gotjosh April 3, 2020 14:42
Copy link

@gotjosh gotjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rfratto rfratto merged commit 4c5050c into v2.17.1-grafana Apr 3, 2020
@rfratto
Copy link
Member Author

rfratto commented Apr 3, 2020

I'm going to rename the release branch to release-2.17.1-grafana so it works better with Go tooling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants