Merge feat-shared-interner to release-2.18.1-grafana #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit exposes the string interner globally with a shared pool and modifies both the scraper and remote_write to use that shared pool. Note that the string_interner_zero_reference_releases_total now has a different namespace and subsystem from what it was initially set to in the RW code. Signed-off-by: Robert Fratto <robert.fratto@grafana.com>
gotjosh
approved these changes
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.18 version of #3
Pretty simple rebase. There was one merge conflict from the old
internLabelsbeing shifted down a few functions upstream, but it was arbitrary to resolve (just remove the function again).