Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to 2.19 #15

Merged
merged 26 commits into from
Nov 17, 2022
Merged

chore: update to 2.19 #15

merged 26 commits into from
Nov 17, 2022

Conversation

korniltsev
Copy link
Collaborator

No description provided.

kevingosse and others added 26 commits November 2, 2022 14:45
…og.Trace (#3401)

* Bump version of DatadogTestLogger to remove direct references to Datadog.Trace

Also
- Remove compilation references to the logger library itself. We only need the lib to be in the bin folder, we don't need it to be referenced
- Simplify the copying of the lib to the bin folder. This happens automatically, except in .NET Core 2.1, we need to set CopyLocalLockFileAssemblies=true

* Bump to 0.0.26 to include logging
* Add timeout to mock API - previously would hang indefinitely

Allow more control around reset event in scenarios that can potentially hang.
Remove potential for lost data in SendTraceAsync (shouldn't happen as single threaded in backend, but seems preferable

* Add test for "setting readonly span" scenario

Currently hangs

* Update source generator to log when we set a tag on a tag list that should be readonly

* Update the source generated tags lists

* PR feedback
* Send benchmark test type as version 1 of the test model.

* fix tests
* Fix ASP.NET ResourceNameHelper case handling

* Extract AspNetCoreResourceNameHelper from diagnostic observer, and add tests

* Fix handling of complex segments in ASP.NET Core
…xed snapshot serialization issues (#3406)

* Properly disabled the Async Method Probe + Fixed serialization issues of Line probe snapshot

* Restored the test `AsyncInstanceMethod` for async line probe

* renamed (unclear) "token" -> "fields"
* Initial commit.

* Fix session

* Changes

* Fixes

* TestModule refactor

* Adds TestSession to the public api.

* Change tests to support TestSession

* Changes from review

* Verbose for debugging.

* stop stacktrace

* temporary disable session creation in tests.

* change session injection to avoid crash other tests.

* Cleanup after all test were fixed.

* fix

* Changes from review.
* Add special ExitCodeException to test suites.

* Changes from review
* Allow setting the working directory when starting a process

* Update AzureFunctions test app

- Runs a timer trigger on start, which calls an HTTP trigger, which calls another HTTP trigger
- Also running a second timer trigger that starts, waits for 10s, then exits the app. This is the easiest approach to configure. This trigger does _not_ generate a span
- remove some of the additional setup as not required

* Rename Samples.AzureFunctions.AllTriggers -> Samples.AzureFunctions.V3InProcess

* Add integration tests for Azure Functions runtime v3 in-process

* Add azure functions integration tests build stage

* Fix Azure Functions trying to update a read-only tag

* Disable azure functions tests in CI because I can't get them to work 😢
* Instrumentation of basic hashing types

* Test case. Exclude by black list approach.

* Instrumentate async computehash call

* Rename variables.

* Rename interation folder

* Add some basic IAST classes

* Add IAST configuration

* Use new IAST category

* Add a IAST module.

* Move files.

* Serialize vulnerability JSON

* Move files

* Move weak hasing sample

* Include filtered filename and line in the span.

* Improve InsecureHashingAlgorithms configuration

* Add nullable enable to classes

* Avoid insecure hashing spans form DD code.

* Add new _dd.iast.enabled tag

* add integration tests

* Improve stack trace detection. Add some integration tests snapshots.

* Merge the net50/net60 differentiation in the integration tests

* Use IAST java classes to build the Json and get the right format

* Move integration test file

* Add category to hash algorithm instrumentation

* Rename hashing tags to iastTags

* Fix hash tests

* remove not needed file

* remove not needed files

* lowcase property names

* Send the algorithm name without the namespace.

* fix tests

* remove location from test

* remove comment

* Renam file names

* Add custom md5 test case

* Exclude stringextension md5 from span generation

* First Insecure cipher sample

* insecure cipher first skeleton

* Basic cipher instrumentation

* Instrumentate weak cipher: avoid onmethodend exception

* Fix double span creatin for tripleDES

* fix compilation errors

* cosmetic fixes

* fix comments

* Instrumentation of basic hashing types

* Add some basic IAST classes

* Add IAST configuration

* Use new IAST category

* Add a IAST module.

* Move files.

* Move files.

* Move files

* Move weak hasing sample

* Add nullable enable to classes

* Add new _dd.iast.enabled tag

* add integration tests

* Improve stack trace detection. Add some integration tests snapshots.

* Use IAST java classes to build the Json and get the right format

* Move integration test file

* Add category to hash algorithm instrumentation

* Rename hashing tags to iastTags

* Fix hash tests

* lowcase property names

* Send the algorithm name without the namespace.

* fix tests

* remove location from test

* Renam file names

* Add vulnerabilty duplication tests

* Add deduplication integration tests

* quick fixes

* fix compilation errors

* Delete InsecureHashingTags.g.cs

* Delete InsecureHashingTags.g.cs

* Delete InsecureHashingTags.g.cs

* Delete IAST.cs

* Delete IASTSettings.cs

* Add scoped namespaces

* Fix indent. Remove not needed snapshots.

* Delete InsecureHashingTags.g.cs

* deduplicated integration test

* Indent program.

* Undo solution unintended changes

* Simplify Iast utils

* Add weak hash controller

* Manage requests through iastRequestContext

* aspnetcore5 tests

* asp netcore 2 iast  integration tests

* move test files.,

* fixes

* new spancontext overload

* avoid null references exceptions

* Add comments, fixes, name changes...

* Delete ConfigurationKeys.IAST.cs

* fix compilation error and tests issues

* Fix integrtion tests

* Fix test

* Get distributedTracer scope

* add comment

* Add iastContext to TraceContext

* Remove not needed namespaces

* Simplify expression

* simplify iastmodule vulnerability method

* Fix null reference exception

* Update tracer/src/Datadog.Trace/IAST/IastModule.cs

Co-authored-by: Lucas Pimentel-Ordyna <lucas.pimentel@datadoghq.com>

* IMprove resource management

* Improve resource management

* set enableIast in separate method

* use locks, small refactor.

* remove origin.

* include all the span types

* fix tests

* Add iast enabled to span when no vulnerability

* Remove not needed code.

* Rename snapshots

* slight improvements

* Update tracer/src/Datadog.Trace/IAST/IastRequestContext.cs

Co-authored-by: Lucas Pimentel-Ordyna <lucas.pimentel@datadoghq.com>

Co-authored-by: Lucas Pimentel-Ordyna <lucas.pimentel@datadoghq.com>
* Add integration tests for Inprocess runtime v4

* Add support for runtime v4 to FunctionInvocationMiddleware

* Update CI to run .NET 6 Functions tests by default

.NET Core 3.1 doesn't work for unknown reasons, but we can enable the .NET 6 tests by default
* Add Test custom configurations support for ITR

* Add tests cases for the DD_TAGS parser.

* Fixes
* add test cases (which fail)

* allow colons in tag value
* Added function to delete files order than 31 days

* Testing that expected files get deleted

* Updated function to find specific files and and not used unbounded arrays

* Added non-tracer files to test and switched to EnumerateFiles

* Moved method to run inside Task.Run

* Added explicit log file names and updated test

* Adding Configuration for Log Files Days

* Updated naming and validated data in the method

* Moving Try Catch and aborting function on first catch

* Updated variable name to match convention

* Updated test assertions and try/catch scope

* Fixing spaces and assertions order

* Removing unused code and fixing nits

* Added default value of 32 days back

* Increasing LastWriteTime for test log file
* Bump datadog logger version to 0.0.28

* bump
…428)

- Mark each function we need to export individually.
* Reintroduce ip collection behind a flag

* Create initial tests and snapshots for IP collection

* Enable IP collection, and verify the snapshots updated correctly

Co-authored-by: Andrew Lock <andrew.lock@datadoghq.com>
…eryService. (#3433)

* CheckAgentConnectionAsync rewrite to use the DiscoveryService only.

* Changes

* changes
* Move SingleSpanSampling into AgentWriter.WriteTrace

* Fix missing parameters in AgentWriter

* Remove duplicate test

* Remove misleading comment

* Remove drop after dispose test

Don't think that is an actual use case.

* Optimize span sampler check from PR feedback

* Change SamplingPriority to be null from SpanContext

* Remove TraceContext null test case that isn't applicable
* Generate samples for Stop The World phases of garbage collector
* Add garbage collection samples to profile with number, generation, reason, type, and compacting
@korniltsev korniltsev marked this pull request as ready for review November 17, 2022 17:12
@korniltsev korniltsev merged commit b55f107 into master Nov 17, 2022
@petethepig petethepig deleted the chore/update_to_2_19 branch November 23, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet