Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover storage/segment with randomized tests #28

Closed
petethepig opened this issue Jan 19, 2021 · 1 comment
Closed

Cover storage/segment with randomized tests #28

petethepig opened this issue Jan 19, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@petethepig
Copy link
Member

petethepig commented Jan 19, 2021

storage/segment is an implementation of a segment tree, somewhat similar to this wikipedia definition.

This allows us to very efficiently store and (arguably more importantly) query years of profiling data very quickly. The problem is that operations on this type of data structure are quite complex, and I already found multiple bugs while working on them (most recently this: 47ebbd9).

To give us some more confidence I think we should add some randomized tests where it would randomly "write" a bunch of data to a simple data structure (e.g just an array) and our segment tree. Then it would read the results from the simple data structure + from the segment tree and compare them.

This way we a) might be able to find more subtle bugs, b) prevent regressions

@petethepig petethepig self-assigned this Jan 19, 2021
@petethepig petethepig added type/bug Something isn't working enhancement New feature or request and removed type/bug Something isn't working labels Jan 19, 2021
@petethepig
Copy link
Member Author

Fixed in #123

korniltsev pushed a commit that referenced this issue Jul 18, 2023
Add version metadata about build correctly into image and metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant