Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up logging on go side #4

Closed
petethepig opened this issue Dec 31, 2020 · 1 comment
Closed

Clean up logging on go side #4

petethepig opened this issue Dec 31, 2020 · 1 comment
Labels
backend Mostly go code 🧹 cleanup Important, but often overlooked. Great first issues help wanted

Comments

@petethepig
Copy link
Member

petethepig commented Dec 31, 2020 •
edited

Currently it's a mess and mostly used for debugging. We should make it look nicer and be actually useful for people using pyroscope, not just developers.

As a part of this we should also add a logging option to the go integration.
@petethepig petethepig added backend Mostly go code 🧹 cleanup Important, but often overlooked. Great first issues help wanted labels Jan 28, 2021
@wolfogre
Copy link

wolfogre commented Feb 24, 2021 •
edited

I couldn't agree more, I can not find any way to disable logging, changing the StandardLogger in logrus may help, but it is a bad idea.

@eh-am eh-am closed this as completed Jul 6, 2022
@petethepig petethepig mentioned this issue May 24, 2023
Merged
chengjoey added a commit to chengjoey/pyroscope that referenced this issue Jun 21, 2023
@chengjoey
perf: speedup insert profile, support format flamebearer (grafana#4)
f6c4ccf 
* speed up insert segment and tree by create new object directly

* not insert useless labels

* support generate front cell table
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend Mostly go code 🧹 cleanup Important, but often overlooked. Great first issues help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@petethepig @eh-am @wolfogre