Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jfr): parser fixes #2286

Merged
merged 6 commits into from
Aug 22, 2023
Merged

fix(jfr): parser fixes #2286

merged 6 commits into from
Aug 22, 2023

Conversation

korniltsev
Copy link
Collaborator

@korniltsev korniltsev commented Aug 21, 2023

The main fix is in frames function

Before the PR it was generating class + "." + function string every time the function was referenced in any stacktrace, now it is generated lazily once per function.

goos: linux
goarch: amd64
pkg: github.com/grafana/pyroscope/pkg/ingester/pyroscope
cpu: AMD Ryzen 9 5950X 16-Core Processor            
                                                                │   old.txt    │               new.txt               │
                                                                │    sec/op    │   sec/op     vs base                │
IngestJFR/cortex-dev-01__kafka-0__cpu_lock0_alloc0__0.jfr.gz-32   149.88m ± 2%   75.19m ± 3%  -49.83% (p=0.000 n=10)

                                                                │   old.txt    │               new.txt                │
                                                                │     B/op     │     B/op      vs base                │
IngestJFR/cortex-dev-01__kafka-0__cpu_lock0_alloc0__0.jfr.gz-32   46.59Mi ± 0%   29.31Mi ± 0%  -37.09% (p=0.000 n=10)

                                                                │   old.txt   │               new.txt               │
                                                                │  allocs/op  │  allocs/op   vs base                │
IngestJFR/cortex-dev-01__kafka-0__cpu_lock0_alloc0__0.jfr.gz-32   543.9k ± 0%   159.4k ± 0%  -70.70% (p=0.000 n=10)

fix bench
improve allocations

TODO

lint

fix scale
Copy link
Collaborator

@kolesnikovae kolesnikovae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@korniltsev korniltsev merged commit 19dd952 into next Aug 22, 2023
17 checks passed
@korniltsev korniltsev deleted the jfr_fixes branch August 22, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants