chore: adds ability to render profile in dot format #2808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please do not merge it – I'm working on it |
kolesnikovae
force-pushed
the
feat/profile-dot-format
branch
from
fe5febc
to
712b21f
Compare
kolesnikovae
reviewed
Dec 6, 2023
Comment on lines
+151
to
+154
| // We probably should distinguish max nodes of the source pprof | ||
| // profile and max nodes value for the output profile in dot format. | ||
| sourceProfileMaxNodes := int64(512) | ||
| dotProfileMaxNodes := int64(100) |
There was a problem hiding this comment.
This is quite important: the less nodes we include into the source, the higher level function will appear in the analysis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.