Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Removes the delta reserved labels from storage. #2920

Merged
merged 2 commits into from
Jan 15, 2024
Merged

refactor: Removes the delta reserved labels from storage. #2920

merged 2 commits into from
Jan 15, 2024

Conversation

cyriltovena
Copy link
Contributor

based @kolesnikovae feedback here #2914 (comment)

I think we should remove the __delta__ reserved labels which is used to disable delta of samples between profiles.

@cyriltovena cyriltovena requested a review from a team as a code owner January 12, 2024 11:09
kolesnikovae
kolesnikovae approved these changes Jan 15, 2024
View reviewed changes
Copy link
Collaborator

@kolesnikovae kolesnikovae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 7007d52 into main Jan 15, 2024
19 checks passed
@cyriltovena cyriltovena deleted the refactoring/remove-delta-labels branch January 15, 2024 12:57
@knylander-grafana knylander-grafana mentioned this pull request Jan 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolesnikovae kolesnikovae kolesnikovae approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyriltovena @kolesnikovae