epbf: Propagate PID namespace to kernel space #3008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
changed the title
simonswine
force-pushed
the
20240215_support-pid-namespaces
branch
from
8aa1b23
to
c206eb3
Compare
|
|
simonswine
force-pushed
the
20240215_support-pid-namespaces
branch
from
c206eb3
to
1222da9
Compare
simonswine
changed the title
simonswine
force-pushed
the
20240215_support-pid-namespaces
branch
from
2450007
to
7bccaa7
Compare
Replace use bpf_get_ns_current_pid_tgid, as it only matches in the exact same namespace and not child namespaces. This iterates up to 4 namespace levels up to find a match.
simonswine
force-pushed
the
20240215_support-pid-namespaces
branch
from
7bccaa7
to
6a396d8
Compare
korniltsev
reviewed
Feb 19, 2024
korniltsev
reviewed
Feb 19, 2024
korniltsev
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the ebpf profiler is running on another namespace than the host PID namespace, then the PIDs that are selected by Grafana Agent are not matching up with the ones collected.
This will respect the PID namespace the original process is running under.
Fixes #3002 #1994
Note this is based on #2996