Context aware autocompletion for macros #171
Conversation
sunker
requested review from
fridgepoet,
kevinwcyu and
andresmgot
and removed request for
a team
|
Backend code coverage report for PR #171 |
|
Frontend code coverage report for PR #171
|
sunker
force-pushed
the
macro-autocomplete
branch
from
f8c026f
to
8f43e0f
Compare
| LanguageCompletionProvider, | ||
| TableDefinition, | ||
| TableIdentifier, | ||
| // getStandardSQLCompletionProvider, |
There was a problem hiding this comment.
also I am geting several errors from this file
There was a problem hiding this comment.
What kind of errors? If you've previously used a locally linked version of grafana/experimental, you may have to make a hard reinstall. yarn install --force && yarn
There was a problem hiding this comment.
the same than in Drone: https://drone.grafana.net/grafana/redshift-datasource/412/1/5
There was a problem hiding this comment.
ah that's right - need to merge this PR first :|
There was a problem hiding this comment.
Think the link above is pointing to another PR. Anyway, should be working fine now!
|
Too many parallel PR now, so closing this in favor of #174 |
This PR is based on #169 so for the time being it includes its diff.
This PR adds context aware autocompletion for redshift macros. Suggestions are context aware in the sense that macros for columns, tables, filters and groups are differentiated. See example below.
Part of #108
Fixes #170