-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for context aware autocompletion #174
Conversation
Backend code coverage report for PR #174 |
Frontend code coverage report for PR #174
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor notes. It makes sense to me overall but I'm going to take another look at it monday to make sure I understand it.
Co-authored-by: Isabella Siu <sakurablossom@blueblueworld.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
This PR switches from using the CodeEditor that was used in the query editor, variable editor and annotation editor with the SQL CodeEditor from grafana/experimental. This adds autocompletion including suggestions for macros, functions, keywords, logical operators, comparison operators etc. Like before, redshift uses a custom language with its own keywords, functions and operators. Also, a custom completion item provider is used so that the plugin can resolve tables and columns that is used by the autocompletion engine.
Fixes #108
Example:
Example with macros: