-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prepare-downscale webhook should check for rollouts #82
Conversation
4474444
to
9fb9fdc
Compare
e71c6d6
to
fff0b8d
Compare
43885b8
to
cc20646
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some minor feedback. Let's see how it works in a dev environment!
Tested in dev-01 by attempting to manually downscale a statefulset during a rollout:
Then a few minutes later, once the pods were ready:
|
This commit updates the prepare-downscale webhook to check for rollouts that are in progress in the rollout-group, by comparing the status.replicas to the readyReplicas and updatedReplicas.
284e7e5
to
0799900
Compare
This PR updates the prepare-downscale webhook to check for rollouts that are in progress in the rollout-group, by comparing the statefulset's Status.UpdatedReplicas to the number of ready and running pods in the group.
This PR also:
Fixes #79