Do not exit reconciliation if scaling errors #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change continues reconciliation if scaling fails, so that updates may proceed if possible.
jhalterman
force-pushed
the
do-not-return-on-scaling-error
branch
from
9529901
to
f267b32
Compare
56quarters
reviewed
Oct 5, 2023
56quarters
approved these changes
Oct 6, 2023
3 tasks
56quarters
added a commit
to grafana/mimir
that referenced
this pull request
Nov 3, 2023
Pulls in fixes to live-lock issues triggered by the combination of HPA scaling changes and rollouts happening at the same time. See grafana/rollout-operator#90 See grafana/rollout-operator#92 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
56quarters
added a commit
to grafana/mimir
that referenced
this pull request
Nov 3, 2023
Pulls in fixes to live-lock issues triggered by the combination of HPA scaling changes and rollouts happening at the same time. See grafana/rollout-operator#90 See grafana/rollout-operator#92 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #82, downscaling attempts are prevented in a zone if some other zone has non-ready pods. One situation where this could happen is if zone-C is rolling around the same time that zone-A starts experiencing evictions. In this case, zone C may also want to downscale some nodes, but is unable to because zone A has non-ready nodes, and since reconciliation exits when downscaling fails, zone C can't finish rolling its pods either.
This change allows reconciliation to continue even if scaling fails, so that updates may proceed.