MultiValueVariable: Fixes issue with initial url sync when using old All url value #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torkelo
added
patch
torkelo
requested review from
a team and
kaydelaney
and removed request for
a team
dprokop
approved these changes
Mar 22, 2024
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #632 made it so that we did not support the old URL value for the ALL VALUE.
This restores the backward compatible support for "All" in URL (changed to $__alll)
📦 Published PR as canary version:
4.0.2--canary.656.8387068694.0✨ Test out this PR locally via:
npm install @grafana/scenes@4.0.2--canary.656.8387068694.0 # or yarn add @grafana/scenes@4.0.2--canary.656.8387068694.0