MultiValueVariable: Fixes support for legacy All url value #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torkelo
added
patch
axelavargas
approved these changes
May 1, 2024
dprokop
approved these changes
May 1, 2024
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes grafana/grafana#87167
A previous fix for this #656 only added a unit test for the scenario where includeAll and isMulti was false (so not truly multi value). when isMulti is true the URL value is an array and so the comparison that checked for the old legacy ALL URL value did not pass as the urlValue was an array with "All"
📦 Published PR as canary version:
4.13.2--canary.712.8910747975.0✨ Test out this PR locally via:
npm install @grafana/scenes@4.13.2--canary.712.8910747975.0 # or yarn add @grafana/scenes@4.13.2--canary.712.8910747975.0