Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AdHocFiltersVariable: create an opt-in state variable for using queries to filter the options #713

Merged
merged 1 commit into from
May 3, 2024
Merged

AdHocFiltersVariable: create an opt-in state variable for using queries to filter the options #713

merged 1 commit into from
May 3, 2024

Conversation

darrenjaneczek
Copy link
Contributor

@darrenjaneczek darrenjaneczek commented May 1, 2024 •
edited
Loading

Instead of using queries by default to filter the options for the AdHocFiltersVariable, make it an opt-in option.

Adds useQueriesAsFilterForOptions to state definition.

Notes:

Related:

@darrenjaneczek
fix: opt-in for using queries to filter ad hoc var
269c202 
Instead of using queries by default to filter the options
for the `AdHocFiltersVariable`, make it an opt-in option.
Adds `useQueriesAsFilterForOptions` to state definition.
@darrenjaneczek darrenjaneczek added type/enhancement New feature or request minor Increment the minor version when merged release Create a release when this pr is merged labels May 2, 2024
@darrenjaneczek darrenjaneczek mentioned this pull request May 2, 2024
Merged
3 tasks
@darrenjaneczek darrenjaneczek merged commit c6e572a into main May 3, 2024
3 checks passed
@darrenjaneczek darrenjaneczek deleted the opt-in/useQueriesAsFilterForOptions branch May 3, 2024 15:12
@grafanabot
Copy link
Contributor

🚀 PR was released in v4.14.0 🚀

@darrenjaneczek darrenjaneczek mentioned this pull request May 3, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsmylife itsmylife itsmylife approved these changes

@torkelo torkelo Awaiting requested review from torkelo

@bfmatei bfmatei Awaiting requested review from bfmatei

@ashharrison90 ashharrison90 Awaiting requested review from ashharrison90

Assignees
No one assigned
Labels
minor Increment the minor version when merged release Create a release when this pr is merged released type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@darrenjaneczek @grafanabot @itsmylife