-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scenes: update to v4.14.0: opt-in to useQueriesAsFilterForOptions
#87244
Merged
darrenjaneczek
merged 2 commits into
main
from
darrenjaneczek/opt-in-adhoc-filter-use-queries
May 3, 2024
Merged
scenes: update to v4.14.0: opt-in to useQueriesAsFilterForOptions
#87244
darrenjaneczek
merged 2 commits into
main
from
darrenjaneczek/opt-in-adhoc-filter-use-queries
May 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR must be merged before a backport PR will be created. |
1 similar comment
This PR must be merged before a backport PR will be created. |
useQueriesAsFilterForOptions
useQueriesAsFilterForOptions
With updating the scenes library, dashboards must now explicitly opt in to `useQueriesAsFilterForOptions`.
270cb1c
to
cc69046
Compare
itsmylife
approved these changes
May 3, 2024
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-87244-to-v11.0.x origin/v11.0.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 5b424ed6bb0bf8f3494d2c74e5d18ce9880512d8 When the conflicts are resolved, stage and commit the changes:
If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-87244-to-v11.0.x
# Create the PR body template
PR_BODY=$(gh pr view 87244 --json body --template 'Backport 5b424ed6bb0bf8f3494d2c74e5d18ce9880512d8 from #87244{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title "[v11.0.x] scenes: update to v4.14.0: opt-in to `useQueriesAsFilterForOptions`" --body-file - --label "type/bug" --label "area/frontend" --label "no-changelog" --label "backport" --base v11.0.x --milestone 11.0.x --web Or, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-87244-to-v11.0.x
# Create a pull request where the `base` branch is `v11.0.x` and the `compare`/`head` branch is `backport-87244-to-v11.0.x`.
# Remove the local backport branch
git switch main
git branch -D backport-87244-to-v11.0.x |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/frontend
backport v11.0.x
Mark PR for automatic backport to v11.0.x
backport-failed
Failed to generate backport PR. Please resolve conflicts and create one manually.
no-changelog
Skip including change in changelog/release notes
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With updating the scenes library, dashboards must now explicitly opt in to
useQueriesAsFilterForOptions
.We want to ensure we opt into this all the time for the new scenes dashboards.
We do not want this behavior for certain scenes apps, like "Explore Metrics"
Updating the library to require opt-in for
useQueriesAsFilterForOptions
fixes a bug in "Explore Metrics" which prevents the adhoc filter varible from being able to select keys and values once the sample panels in the select metrics scene have been initialized.Depends on:
Special notes for your reviewer:
Please check that: