fix: undefined check on RefreshPicker.autoOption #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix prevents some of the demos from failing due to the `undefined` autoOption.
torkelo
approved these changes
May 27, 2024
|
🚀 PR was released in |
ivanortegaalba
added a commit
to grafana/grafana
that referenced
this pull request
May 30, 2024
# v4.24.4 (Thu May 30 2024) #### 🐛 Bug Fix - `@grafana/scenes` - VizPanelRenderer: Emit SetPanelAttention event [#716](grafana/scenes#716) ([@tskarhed](https://github.com/tskarhed)) #### Authors: 1 - Tobias Skarhed ([@tskarhed](https://github.com/tskarhed)) --- # v4.24.3 (Thu May 30 2024) #### 🐛 Bug Fix - `@grafana/scenes` - Macros: Resolve browser timezone for `$__timezone` [#759](grafana/scenes#759) ([@ivanortegaalba](https://github.com/ivanortegaalba)) - Variables: Prioritize showing adhoc variable key and operator [#750](grafana/scenes#750) ([@oscarkilhed](https://github.com/oscarkilhed)) #### Authors: 2 - Ivan Ortega Alba ([@ivanortegaalba](https://github.com/ivanortegaalba)) - Oscar Kilhed ([@oscarkilhed](https://github.com/oscarkilhed)) --- # v4.24.2 (Wed May 29 2024) #### 🐛 Bug Fix - `@grafana/scenes` - MultiValueVariable: Fixes issue when value is all value but all value is not enabled [#757](grafana/scenes#757) ([@torkelo](https://github.com/torkelo) [@ivanortegaalba](https://github.com/ivanortegaalba)) #### Authors: 2 - Ivan Ortega Alba ([@ivanortegaalba](https://github.com/ivanortegaalba)) - Torkel Ödegaard ([@torkelo](https://github.com/torkelo)) --- # v4.24.1 (Tue May 28 2024) #### 🐛 Bug Fix - Plugin.json: update schema reference URL in scenes-app [#754](grafana/scenes#754) ([@leventebalogh](https://github.com/leventebalogh)) - `@grafana/scenes` - Allow drag and dropping rows in valid states [#756](grafana/scenes#756) ([@mdvictor](https://github.com/mdvictor)) - fix: undefined check on RefreshPicker.autoOption [#751](grafana/scenes#751) ([@darrenjaneczek](https://github.com/darrenjaneczek)) #### Authors: 3 - Darren Janeczek ([@darrenjaneczek](https://github.com/darrenjaneczek)) - Levente Balogh ([@leventebalogh](https://github.com/leventebalogh)) - Victor Marin ([@mdvictor](https://github.com/mdvictor)) --- # v4.24.0 (Mon May 27 2024) #### 🚀 Enhancement - `@grafana/scenes` - SceneFlexLayout: Min width/height option was ignored [#749](grafana/scenes#749) ([@edvard-falkskar](https://github.com/edvard-falkskar)) #### Authors: 1 - Edvard Falkskär ([@edvard-falkskar](https://github.com/edvard-falkskar)) ---
ivanortegaalba
added a commit
to grafana/grafana
that referenced
this pull request
May 30, 2024
- `@grafana/scenes` - VizPanelRenderer: Emit SetPanelAttention event [#716](grafana/scenes#716) ([@tskarhed](https://github.com/tskarhed)) - Tobias Skarhed ([@tskarhed](https://github.com/tskarhed)) --- - `@grafana/scenes` - Macros: Resolve browser timezone for `$__timezone` [#759](grafana/scenes#759) ([@ivanortegaalba](https://github.com/ivanortegaalba)) - Variables: Prioritize showing adhoc variable key and operator [#750](grafana/scenes#750) ([@oscarkilhed](https://github.com/oscarkilhed)) - Ivan Ortega Alba ([@ivanortegaalba](https://github.com/ivanortegaalba)) - Oscar Kilhed ([@oscarkilhed](https://github.com/oscarkilhed)) --- - `@grafana/scenes` - MultiValueVariable: Fixes issue when value is all value but all value is not enabled [#757](grafana/scenes#757) ([@torkelo](https://github.com/torkelo) [@ivanortegaalba](https://github.com/ivanortegaalba)) - Ivan Ortega Alba ([@ivanortegaalba](https://github.com/ivanortegaalba)) - Torkel Ödegaard ([@torkelo](https://github.com/torkelo)) --- - Plugin.json: update schema reference URL in scenes-app [#754](grafana/scenes#754) ([@leventebalogh](https://github.com/leventebalogh)) - `@grafana/scenes` - Allow drag and dropping rows in valid states [#756](grafana/scenes#756) ([@mdvictor](https://github.com/mdvictor)) - fix: undefined check on RefreshPicker.autoOption [#751](grafana/scenes#751) ([@darrenjaneczek](https://github.com/darrenjaneczek)) - Darren Janeczek ([@darrenjaneczek](https://github.com/darrenjaneczek)) - Levente Balogh ([@leventebalogh](https://github.com/leventebalogh)) - Victor Marin ([@mdvictor](https://github.com/mdvictor)) --- - `@grafana/scenes` - SceneFlexLayout: Min width/height option was ignored [#749](grafana/scenes#749) ([@edvard-falkskar](https://github.com/edvard-falkskar)) - Edvard Falkskär ([@edvard-falkskar](https://github.com/edvard-falkskar)) --- (cherry picked from commit c5ae0bb)
miguelmolina95
pushed a commit
to miguelmolina95/grafana
that referenced
this pull request
Jun 3, 2024
# v4.24.4 (Thu May 30 2024) #### 🐛 Bug Fix - `@grafana/scenes` - VizPanelRenderer: Emit SetPanelAttention event [grafana#716](grafana/scenes#716) ([@tskarhed](https://github.com/tskarhed)) #### Authors: 1 - Tobias Skarhed ([@tskarhed](https://github.com/tskarhed)) --- # v4.24.3 (Thu May 30 2024) #### 🐛 Bug Fix - `@grafana/scenes` - Macros: Resolve browser timezone for `$__timezone` [grafana#759](grafana/scenes#759) ([@ivanortegaalba](https://github.com/ivanortegaalba)) - Variables: Prioritize showing adhoc variable key and operator [grafana#750](grafana/scenes#750) ([@oscarkilhed](https://github.com/oscarkilhed)) #### Authors: 2 - Ivan Ortega Alba ([@ivanortegaalba](https://github.com/ivanortegaalba)) - Oscar Kilhed ([@oscarkilhed](https://github.com/oscarkilhed)) --- # v4.24.2 (Wed May 29 2024) #### 🐛 Bug Fix - `@grafana/scenes` - MultiValueVariable: Fixes issue when value is all value but all value is not enabled [grafana#757](grafana/scenes#757) ([@torkelo](https://github.com/torkelo) [@ivanortegaalba](https://github.com/ivanortegaalba)) #### Authors: 2 - Ivan Ortega Alba ([@ivanortegaalba](https://github.com/ivanortegaalba)) - Torkel Ödegaard ([@torkelo](https://github.com/torkelo)) --- # v4.24.1 (Tue May 28 2024) #### 🐛 Bug Fix - Plugin.json: update schema reference URL in scenes-app [grafana#754](grafana/scenes#754) ([@leventebalogh](https://github.com/leventebalogh)) - `@grafana/scenes` - Allow drag and dropping rows in valid states [grafana#756](grafana/scenes#756) ([@mdvictor](https://github.com/mdvictor)) - fix: undefined check on RefreshPicker.autoOption [grafana#751](grafana/scenes#751) ([@darrenjaneczek](https://github.com/darrenjaneczek)) #### Authors: 3 - Darren Janeczek ([@darrenjaneczek](https://github.com/darrenjaneczek)) - Levente Balogh ([@leventebalogh](https://github.com/leventebalogh)) - Victor Marin ([@mdvictor](https://github.com/mdvictor)) --- # v4.24.0 (Mon May 27 2024) #### 🚀 Enhancement - `@grafana/scenes` - SceneFlexLayout: Min width/height option was ignored [grafana#749](grafana/scenes#749) ([@edvard-falkskar](https://github.com/edvard-falkskar)) #### Authors: 1 - Edvard Falkskär ([@edvard-falkskar](https://github.com/edvard-falkskar)) ---
ivanortegaalba
added a commit
to grafana/grafana
that referenced
this pull request
Jun 12, 2024
Scenes: Update to latest 4.23.1 -> 4.24.4 (#88485) - `@grafana/scenes` - VizPanelRenderer: Emit SetPanelAttention event [#716](grafana/scenes#716) ([@tskarhed](https://github.com/tskarhed)) - Tobias Skarhed ([@tskarhed](https://github.com/tskarhed)) --- - `@grafana/scenes` - Macros: Resolve browser timezone for `$__timezone` [#759](grafana/scenes#759) ([@ivanortegaalba](https://github.com/ivanortegaalba)) - Variables: Prioritize showing adhoc variable key and operator [#750](grafana/scenes#750) ([@oscarkilhed](https://github.com/oscarkilhed)) - Ivan Ortega Alba ([@ivanortegaalba](https://github.com/ivanortegaalba)) - Oscar Kilhed ([@oscarkilhed](https://github.com/oscarkilhed)) --- - `@grafana/scenes` - MultiValueVariable: Fixes issue when value is all value but all value is not enabled [#757](grafana/scenes#757) ([@torkelo](https://github.com/torkelo) [@ivanortegaalba](https://github.com/ivanortegaalba)) - Ivan Ortega Alba ([@ivanortegaalba](https://github.com/ivanortegaalba)) - Torkel Ödegaard ([@torkelo](https://github.com/torkelo)) --- - Plugin.json: update schema reference URL in scenes-app [#754](grafana/scenes#754) ([@leventebalogh](https://github.com/leventebalogh)) - `@grafana/scenes` - Allow drag and dropping rows in valid states [#756](grafana/scenes#756) ([@mdvictor](https://github.com/mdvictor)) - fix: undefined check on RefreshPicker.autoOption [#751](grafana/scenes#751) ([@darrenjaneczek](https://github.com/darrenjaneczek)) - Darren Janeczek ([@darrenjaneczek](https://github.com/darrenjaneczek)) - Levente Balogh ([@leventebalogh](https://github.com/leventebalogh)) - Victor Marin ([@mdvictor](https://github.com/mdvictor)) --- - `@grafana/scenes` - SceneFlexLayout: Min width/height option was ignored [#749](grafana/scenes#749) ([@edvard-falkskar](https://github.com/edvard-falkskar)) - Edvard Falkskär ([@edvard-falkskar](https://github.com/edvard-falkskar)) --- (cherry picked from commit c5ae0bb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
autoOptionis undefined, the error prevents some of the demos from displaying.Moved the fix out of:
so it can be merged earlier.