allow colons in http header values

grafana · Jan 24, 2023 · db8b550 · db8b550
1 parent 9d183e7
commit db8b550
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/pkg/pb/synthetic_monitoring/checks_extra.go b/pkg/pb/synthetic_monitoring/checks_extra.go
@@ -472,8 +472,8 @@ func (s *PingSettings) Validate() error {
 
 func (s *HttpSettings) Validate() error {
 	for _, h := range s.Headers {
-		fields := strings.Split(h, ":")
-		if len(fields) != 2 {
+		fields := strings.SplitN(h, ":", 2)
+		if len(fields) < 2 {
 			return ErrInvalidHttpHeaders
 		}
 
@@ -505,8 +505,8 @@ func (s *HttpSettings) Validate() error {
 	}
 
 	for _, h := range s.ProxyConnectHeaders {
-		fields := strings.Split(h, ":")
-		if len(fields) != 2 {
+		fields := strings.SplitN(h, ":", 2)
+		if len(fields) < 2 {
 			return ErrInvalidProxyConnectHeaders
 		}
 

diff --git a/pkg/pb/synthetic_monitoring/checks_extra_test.go b/pkg/pb/synthetic_monitoring/checks_extra_test.go
@@ -910,6 +910,12 @@ func TestHttpSettingsValidate(t *testing.T) {
 			},
 			expectError: true,
 		},
+		"multiple colons": {
+			input: HttpSettings{
+				Headers: []string{"origin:https://www.grafana.com"},
+			},
+			expectError: false,
+		},
 		"invalid name": {
 			input: HttpSettings{
 				Headers: []string{"hea;der: value"},