grpc: Send known checks to API on connect #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriansr
force-pushed
the
reduce_grpc_initial_changes
branch
from
e0e1ab6
to
8a11e3b
Compare
Updates the changes logic to send the existing checks to the API server so that a reduced set of probes can be returned. This results in a reduced memory and network footprint on the API side when the connection is lost or the API restarted.
adriansr
force-pushed
the
reduce_grpc_initial_changes
branch
from
8a11e3b
to
63d81da
Compare
mem
approved these changes
Oct 18, 2022
mem
added a commit
that referenced
this pull request
Nov 3, 2022
* Fix: handle connection state changes * grpc: Send known checks to API on connect (#351) * Chore(deps): Bump google.golang.org/grpc from 1.48.0 to 1.49.0 * Chore(deps): Bump github.com/rs/zerolog from 1.27.0 to 1.28.0 * Chore(deps): Bump github.com/prometheus/client_golang * Enable GRPC keep-alive in connection to API server (#342) * Update tools * Add very simple code to publish k6 metrics and logs * Add nfpm packaging to goreleaser config (#339) * Add goreleaser configuration * Add CODE_OF_CONDUCT.md * build: prevent invalid os/arch combinations (#336) * Add tests for cmd/test-api/internal/db * Add minimal code to run K6 checks * An small (and possibly incorrect) implementation of the API Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the changes logic to send the existing checks to the API server so that a reduced set of probes can be returned.
This results in a reduced memory and network footprint on the API side when the connection is lost or the API restarted and all probes connect at the same time.