Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oauth2 support to HTTP checks #377

Merged
merged 4 commits into from
Nov 30, 2022
Merged

Add oauth2 support to HTTP checks #377

merged 4 commits into from
Nov 30, 2022

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented Nov 28, 2022

This adds support for checks that include OAuth2 settings. It requires:

  • client ID and secret, for authentication.
  • URL for the token endpoint, to obtain a token.
  • A list of scopes, service-specific.
  • An additional list of endpoint parameters (key-value pairs) that are passed to the token endpoint as additional POST fields.
  • Optional Proxy and TLS settings

Relates #356

This adds support for checks that include OAuth2 settings. It requires:
 - client ID and secret, for authentication.
 - URL for the token endpoint, to obtain a token.
 - A list of scopes, service-specific.
 - An additional list of endpoint parameters (key-value pairs) that
   are passed to the token endpoint as additional POST fields.
@adriansr adriansr requested a review from a team as a code owner November 28, 2022 20:46
@adriansr adriansr mentioned this pull request Nov 28, 2022
6 tasks
@adriansr adriansr merged commit 257e2f6 into grafana:main Nov 30, 2022
mem added a commit that referenced this pull request Nov 30, 2022
This release includes fixes for the security issue detailed in:

GHSA-9j4f-f249-q5w8

Thanks to https://github.com/iamwillbar for reporting the issue.

* Add oauth2 support to HTTP checks (#377)
* adhoc: Reorder validation of adhoc checks
* Create SECURITY.md
* Fix: default to listening on localhost, not all interfaces
* Fix: allow getting API token from environment

Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants