Feature: update BBE to version 0.23.0 #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exposes a new metric, probe_dns_query_succeeded, which is set to 1 after the query is sent to the DNS server and the server responds. This allows the user to differentiate between cases when the server failed to respond (and the probe is reported as having failed) vs the server responding with somehting that causes the probe to fail. In other words, probe_success set to 0 but probe_dns_query_succeeded not set means the DNS server failed to respond, while probe_success set to 0 and probe_dns_query_succeeded set to 1 means the server responded but the probe failed for a different reason (e.g. the record does not exist). Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes a new metric, probe_dns_query_succeeded, which is set to 1 after the query is sent to the DNS server and the server responds. This allows the user to differentiate between cases when the server failed to respond (and the probe is reported as having failed) vs the server responding with somehting that causes the probe to fail. In other words, probe_success set to 0 but probe_dns_query_succeeded not set means the DNS server failed to respond, while probe_success set to 0 and probe_dns_query_succeeded set to 1 means the server responded but the probe failed for a different reason (e.g. the record does not exist).
Signed-off-by: Marcelo E. Magallon marcelo.magallon@grafana.com