Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multihttp check type #425

Merged
merged 1 commit into from
May 18, 2023
Merged

Add multihttp check type #425

merged 1 commit into from
May 18, 2023

Conversation

mem
Copy link
Contributor

@mem mem commented Apr 1, 2023

This supports the multihttp check type.

This shoud be used in tandem with sm-k6-runner (the address should be specified as a command line option).

@mem mem requested a review from a team as a code owner April 1, 2023 18:37
@mem mem marked this pull request as draft April 1, 2023 18:37
@mem mem force-pushed the start_k6_script_template branch 2 times, most recently from eeb1779 to c0ad6a4 Compare May 17, 2023 14:28
case sm.MultiHttpEntryAssertionSubjectVariant_RESPONSE_BODY:
cond.Name(&b, "body", assertion.Value)
b.WriteString(`': response => `)
cond.Render(&b, "response.body", assertion.Value)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to perform variable replacements.

if the input looks like ${foo} it needs to be replaced by vars['foo'] so that variables are used...

@mem mem force-pushed the start_k6_script_template branch from c0ad6a4 to 0338daf Compare May 18, 2023 15:58
@mem mem marked this pull request as ready for review May 18, 2023 15:58
@mem mem force-pushed the start_k6_script_template branch 3 times, most recently from 1185a1b to 170036e Compare May 18, 2023 21:05
This supports the multihttp check type. It's not yet connected to the
API (i.e. it might receive a multihttp check from the API but it won't
run it).

Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
@mem mem force-pushed the start_k6_script_template branch from 170036e to a9099d6 Compare May 18, 2023 21:52
@mem mem merged commit 0f17bab into main May 18, 2023
2 checks passed
@mem mem deleted the start_k6_script_template branch May 18, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant