build: Don't expose drone secrets on PR builds #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drone runs for PRs don't have access to secrets anymore, so skip this step for PR builds and keep it for releases and merges to main.
adriansr
changed the title
adriansr
changed the title
This reverts commit 2e4059a.
rdubrock
approved these changes
Apr 19, 2023
adriansr
added a commit
that referenced
this pull request
Apr 19, 2023
* fix: Use Go 1.20.3 to build Agent (#430) * build: Don't expose drone secrets on PR builds (#431) * Chore(deps): Bump github.com/miekg/dns from 1.1.50 to 1.1.52 * Chore(deps): Bump kernel.org/pub/linux/libs/security/libcap/cap * Chore(deps): Bump github.com/prometheus/prometheus from 0.42.0 to 0.43.0 * Chore(deps): Bump golang.org/x/text from 0.3.7 to 0.3.8 in /scripts/go * Chore(deps): Bump github.com/stretchr/testify from 1.8.1 to 1.8.2 * Chore(deps): Bump google.golang.org/grpc from 1.52.3 to 1.54.0 * Add status to the log entry for publisher errors * Update github.com/prometheus/common to v0.42.0 * Update github.com/prometheus/prometheus to v0.42.0 (2.42.0) Signed-off-by: Adrian Serrano <adrisr83@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to security reasons Drone CI secrets are not exposed when the pull request is from a fork. That is why pipeline steps requiring secrets should be skipped.