Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MultiHttp to SM proto #442

Merged
merged 1 commit into from
May 11, 2023
Merged

Add MultiHttp to SM proto #442

merged 1 commit into from
May 11, 2023

Conversation

mem
Copy link
Contributor

@mem mem commented May 10, 2023

This is just the proto and some validations, nothing else.

@mem mem requested a review from a team as a code owner May 10, 2023 20:46
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a lot of noise in this file because I had to reformat it to clean it up.

Copy link
Contributor

@rdubrock rdubrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! One thing that would be cool at some point would be to generate typescript defs from the proto file, because we've duplicated all this stuff on the frontend

This is just the proto and some validations, nothing else.

Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
@mem mem force-pushed the update_proto_for_multihttp branch from 8a979fd to 8947a91 Compare May 11, 2023 19:49
@mem mem merged commit e29b3e2 into main May 11, 2023
2 checks passed
@mem mem deleted the update_proto_for_multihttp branch May 11, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants