Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default k8s version to 1.29 #1010

Merged
merged 1 commit into from
May 13, 2024
Merged

Update default k8s version to 1.29 #1010

merged 1 commit into from
May 13, 2024

Conversation

dan-os
Copy link
Contributor

@dan-os dan-os commented Mar 15, 2024

Hello 👋

It seems that support for Kubernetes versions 1.20 through 1.25 were recently removed from k8s-libsonnet by this commit: jsonnet-libs/k8s-libsonnet@90d0fae. Since then, tk init (without the --k8s flag set) fails by default since the files for 1.20 are no longer available. See example below.

$ tk init

GET https://github.com/jsonnet-libs/k8s-libsonnet/archive/bf9a62cfd32a58c071b8410bfcdec058475dd25e.tar.gz 200
panic: rename /Users/root/project/vendor/.tmp/28d5d0cf4e0847d16afe3035627683a62705765237/1.20 /Users/root/project/vendor/github.com/jsonnet-libs/k8s-libsonnet/1.20: no such file or directory
[...]
Installing k.libsonnet: exit status 2

I've proposed updating the defaultK8sVersion flag for the init command to instead use the latest stable version, 1.29.

Cheers!

@CLAassistant
Copy link

CLAassistant commented Mar 15, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@jvrplmlmn jvrplmlmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jvrplmlmn jvrplmlmn merged commit 5187c3c into grafana:main May 13, 2024
7 of 8 checks passed
@dan-os dan-os deleted the patch-1 branch May 13, 2024 12:57
This was referenced May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants